Trigger hook on parent array property#108
Draft
undjike wants to merge 3 commits intolivewire:mainfrom
Draft
Conversation
Collaborator
|
If we are going to merge this it should probably handle your last case of deep subkeys. |
Collaborator
|
Mark as ready for review again when you want me to take another look please. Thanks! |
Author
|
Added support for deep subkeys. Hope the codebase is still in line with the package behaviour. |
Author
|
Hello @taylorotwell any comment ? |
Author
|
@taylorotwell let me know if there is something you want me to adjust. |
|
@undjike @taylorotwell any updates on this PR? |
|
Any updates here? |
|
Is there any update on this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #107.
It allows triggering the update hook on the parent array property when a change is made to a key.
Before :
When updating on a key, the hook is only triggered for that key.
With this PR :
When updating on a key, the hook is triggered on the parent array, if not explicitly listening for changes to the key.
That said... I'm wondering whether we should make it more dynamic to handle deep subkey as well.
This PR will forward the hook to the parent property
profilesnot toprofiles.admin.